From 3ec798fe5a09845a54aee88a2fe3e107f7fa1bd7 Mon Sep 17 00:00:00 2001 From: lennondotw Date: Fri, 3 Apr 2026 14:44:04 +0800 Subject: [PATCH] fix(useMediaQuery): remove asymmetric addListener/removeListener fallback in unsubscribe createQueryEntry uses addEventListener unconditionally, but queryUnsubscribe still had a removeEventListener/removeListener fallback. This asymmetry is unnecessary since all supported browsers now have addEventListener on MediaQueryList. --- src/useMediaQuery/index.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/useMediaQuery/index.ts b/src/useMediaQuery/index.ts index 92fa79ef..681c2600 100644 --- a/src/useMediaQuery/index.ts +++ b/src/useMediaQuery/index.ts @@ -47,11 +47,7 @@ const queryUnsubscribe = (query: string, setState: QueryStateSetter): void => { if (dispatchers.size === 0) { queriesMap.delete(query); - if (mql.removeEventListener) { - mql.removeEventListener('change', listener); - } else { - mql.removeListener(listener); - } + mql.removeEventListener('change', listener); } } };