[FEATURE] Add "Never Worked" platform history state for regression tests#1084
Draft
Rustix69 wants to merge 2 commits intoCCExtractor:masterfrom
Draft
[FEATURE] Add "Never Worked" platform history state for regression tests#1084Rustix69 wants to merge 2 commits intoCCExtractor:masterfrom
Rustix69 wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
Surfaces tests that have never passed on any platform via a new never_worked property on RegressionTest, a Platform History column on the regression index and by-sample views, and per-platform history detail on the test view page.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Surfaces tests that have never passed on any platform via a new
never_workedproperty onRegressionTest, a Platform History column on the regression index and by-sample views, and per-platform history detail on the test view page.Description
Currently the platform only tracks
last_passed_on_linuxandlast_passed_on_windowscolumns but never surfaces aNULLvalue meaningfully to users. There is no way to distinguish a test that used to pass but now fails from one that has never passed on any version of CCExtractor.This PR introduces the "Never Worked" state as described in the project goals:
never_workedproperty toRegressionTestthat returnsTruewhen both platform columns areNULLThe data already exists in the nullable
last_passed_on_linux/last_passed_on_windowscolumns.In raising this pull request, I confirm the following:
My familiarity with the project is as follows:
Snapshot