Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Alarm clock#1167
Open
marthak1 wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Alarm clock#1167marthak1 wants to merge 3 commits intoCodeYourFuture:mainfrom
marthak1 wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
marthak1
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 4, 2026
Comment on lines
+1
to
+2
| const title = document.querySelector('title') | ||
| title.textContent = "Alarm clock app"; |
There was a problem hiding this comment.
Why did you undo the change where you changed the title in the HTML first?
| let seconds = num % 60; | ||
| return minutes.toString().padStart(2, '0') + ":" + seconds.toString().padStart(2, '0'); | ||
| } | ||
| function setAlarm() { |
There was a problem hiding this comment.
What happens when a user clicks the set alarm button while the countdown is already running?
| } | ||
| function setAlarm() { | ||
| const alarmSetInputEl = document.getElementById("alarmSet"); | ||
| let timeEl = Number(alarmSetInputEl.value); |
There was a problem hiding this comment.
What happens if the user enters a negative number or a non number string?
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Built alarm clock app as per requirements