fix: make reasoning.exclude option actually suppress reasoning tokens#495
Open
hiSandog wants to merge 1 commit intoCodebuffAI:mainfrom
Open
fix: make reasoning.exclude option actually suppress reasoning tokens#495hiSandog wants to merge 1 commit intoCodebuffAI:mainfrom
hiSandog wants to merge 1 commit intoCodebuffAI:mainfrom
Conversation
The previous implementation used a `continue` inside an inner for-loop, which only skipped to the next provider iteration instead of preventing the `yield` of reasoning-delta chunks. Replaced with `.some()` so the exclude check correctly controls whether to yield the reasoning chunk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
reasoning.excludeoption inproviderOptionsfor OpenRouter/Codebuff providers was completely non-functional. SettingproviderOptions.openrouter.reasoning.exclude = truewould not suppress reasoning tokens from the stream.Root Cause
In
sdk/src/impl/llm.ts, thecontinuestatement was inside an innerforloop over providers, so it only skipped to the next provider iteration — theyieldon the following line was unconditionally reached regardless.Fix
Replaced the inner
forloop with.some()so the exclude flag correctly controls whether reasoning chunks are yielded:Validation
OpenRouterProviderOptionstype still used identically