Add i18n support and improve conversation UI behavior#591
Add i18n support and improve conversation UI behavior#591DamnCrab wants to merge 2 commits intoDimillian:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0472cfce9b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/features/settings/components/sections/SettingsDisplaySection.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be5a1dd927
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| compactCandidates.forEach((threadId) => { | ||
| loadedThreadsRef.current[threadId] = false; |
There was a problem hiding this comment.
Marking compacted threads as loaded=false here is not enough to trigger a reload, because setActiveThreadId later treats any thread with remaining cached items as a local snapshot (hasLocalThreadSnapshot checks itemsByThreadRef.current[threadId]?.length > 0) and returns early without calling resumeThreadForWorkspace. In practice, once an inactive thread is compacted to 32 items, switching back to it can permanently show only the truncated tail until a manual sync, which breaks expected history continuity for reopened threads.
Useful? React with 👍 / 👎.
| onWheelCapture={handleUserScrollIntent} | ||
| onTouchStartCapture={handleUserScrollIntent} |
There was a problem hiding this comment.
Fresh evidence relative to the prior pointer-down report: the new onWheelCapture/onTouchStartCapture wiring still calls handleUserScrollIntent unconditionally, so auto-follow is disabled before any real scroll displacement is confirmed. A downward wheel at the bottom (or a simple touchstart tap) can fire without a subsequent scroll change, leaving auto-scroll disabled while messages stream, and users must scroll away and back to recover. This should only mark manual scroll intent after detecting a meaningful upward/away-from-bottom movement.
Useful? React with 👍 / 👎.
|
Review: This PR is quite large (~100 files). Key areas verified: i18n integration looks solid, auto-scroll preservation and locale reset fixes are targeted. The Git diff improvements in git_ui_core show good test coverage (221 new test lines). Message viewport handling and composer dictation test additions are positive. Consider breaking future UI PRs of this size into stacked PRs for easier review. LGTM pending CI pass. |
2 participants
Summary
This PR adds i18n support across recently updated app surfaces and improves conversation UI behavior on top of the latest upstream
main.The main focus is introducing translated handling for user-facing text in updated areas of the app, while also fixing a set of conversation-related interaction issues around scrolling, tool calls, command output, and terminal paste behavior.
What’s included