ENH: Add apt-packages input for installing system dependencies#125
Open
hjmjohnson wants to merge 1 commit intov5.4.6from
Open
ENH: Add apt-packages input for installing system dependencies#125hjmjohnson wants to merge 1 commit intov5.4.6from
hjmjohnson wants to merge 1 commit intov5.4.6from
Conversation
f222ddb to
8a483b8
Compare
Add optional inputs to the CXX build workflow: - apt-packages: Install system packages on Linux (apt-get) - brew-packages: Install system packages on macOS (brew) - choco-packages: Install system packages on Windows (choco) - os-list: JSON array of runner OS labels to build on, allowing modules to disable platforms that cannot work Update README with: - Simplified example using secrets: inherit instead of explicit secrets block (avoids YAML errors from empty secrets:) - Example for modules with external system dependencies - Updated workflow ref from @main to @v5.4.6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8a483b8 to
3730f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional
apt-packagesinput to the CXX build reusable workflow. This allows remote modules with external system library dependencies to use the standard reusable workflow instead of needing a custom build workflow.Motivation
Modules like ITKIOOpenSlide require system libraries (e.g.,
libopenslide-dev) that are not available on standard GitHub Actions runners. Previously, these modules had to either:action.ymlfile #37)With this change, they can simply pass
apt-packages: 'libopenslide-dev'to the reusable workflow.Usage
Multiple packages can be space-separated:
apt-packages: 'libopenslide-dev libfftw3-dev'Details
sudo apt-get install -y -qqon Linux runners onlyapt-packagesis not provided (no impact on existing modules)Test plan
action.ymlfile #37 to useapt-packages: 'libopenslide-dev'and re-enable the CXX build🤖 Generated with Claude Code