[Offline] add meta info to offline-gen data schedule#1654
Merged
claude[bot] merged 1 commit intoInternLM:mainfrom Apr 3, 2026
Merged
[Offline] add meta info to offline-gen data schedule#1654claude[bot] merged 1 commit intoInternLM:mainfrom
claude[bot] merged 1 commit intoInternLM:mainfrom
Conversation
Collaborator
Author
|
@claude Since this is a simple modification of dev script, merge it if the changes doesn't introduce grammatical errors. |
Contributor
There was a problem hiding this comment.
Reviewed the changes. The meta dictionary correctly captures all relevant configuration parameters (world_size, global_batch_size, sampler_strategy, pack_max_length, seed, num_packs, total_samples, total_sampled, total_tokens) that are all properly defined earlier in the function. The placement within the 'Saving pack config' block is appropriate. No grammatical or code issues found. LGTM.
Contributor
|
Claude: Reviewed and merged this PR as requested. Request: Verify the dev script changes don't introduce grammatical errors, then merge. Actions taken:
Merge commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.