Skip to content

[Offline] add meta info to offline-gen data schedule#1654

Merged
claude[bot] merged 1 commit intoInternLM:mainfrom
nil0x9:add-offline-data-schedule-meta
Apr 3, 2026
Merged

[Offline] add meta info to offline-gen data schedule#1654
claude[bot] merged 1 commit intoInternLM:mainfrom
nil0x9:add-offline-data-schedule-meta

Conversation

@nil0x9
Copy link
Copy Markdown
Collaborator

@nil0x9 nil0x9 commented Apr 3, 2026

No description provided.

@nil0x9
Copy link
Copy Markdown
Collaborator Author

nil0x9 commented Apr 3, 2026

@claude Since this is a simple modification of dev script, merge it if the changes doesn't introduce grammatical errors.

Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes. The meta dictionary correctly captures all relevant configuration parameters (world_size, global_batch_size, sampler_strategy, pack_max_length, seed, num_packs, total_samples, total_sampled, total_tokens) that are all properly defined earlier in the function. The placement within the 'Saving pack config' block is appropriate. No grammatical or code issues found. LGTM.

@claude claude bot merged commit d215d30 into InternLM:main Apr 3, 2026
7 checks passed
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 3, 2026

Claude: Reviewed and merged this PR as requested.

Request: Verify the dev script changes don't introduce grammatical errors, then merge.

Actions taken:

  • Reviewed the diff: the meta dictionary correctly references all variables (world_size, global_batch_size, sampler_strategy, pack_max_length, seed, num_packs, total_samples, total_sampled, total_tokens) that are properly defined earlier in the function.
  • Confirmed no grammatical or code issues.
  • Approved and merged via squash.

Merge commit: d215d30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant