fix cors function for alpine linux#4091
Draft
khassel wants to merge 2 commits intoMagicMirrorOrg:developfrom
Draft
fix cors function for alpine linux#4091khassel wants to merge 2 commits intoMagicMirrorOrg:developfrom
khassel wants to merge 2 commits intoMagicMirrorOrg:developfrom
Conversation
Collaborator
Author
|
to late to fix this now ... |
Collaborator
|
Yes, I had that problem with my previous PR and I think I have a solution. Can I add a commit? |
Collaborator
Author
|
sure |
Collaborator
|
The problem was in the destructuring of Ah, and on top of that, the spy was originally on |
KristjanESPERANTO
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I provide docker images with alpine linux and tested the new cors approach.
It didn't work because after calling
the dispatcher variable was undefined.
This PR solves this and I tested this under debian too.
The mix of internal fetch and newer undici did not work and alpine needs additionally the
process.nextTick.