fix(build): use packaging instead of relying on pkg_resources from setuptools#742
Open
samypr100 wants to merge 1 commit intoMagicStack:masterfrom
Open
fix(build): use packaging instead of relying on pkg_resources from setuptools#742samypr100 wants to merge 1 commit intoMagicStack:masterfrom
samypr100 wants to merge 1 commit intoMagicStack:masterfrom
Conversation
Author
|
Should've checked other PRs and issues. Apologies.
Upon reviewing, they're both missing some important areas that needed to be addressed (e.g. Note, the CI failures on 3.13.12 (less prominent on 3.13.11) and 3.14.3 (less prominent on 3.14.2) pipelines on These unrelated failures would be fixed by #743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build uvloop locally, I ended up encountering the issues mentioned in pypa/setuptools#5174
Reliance of
pkg_resourcescausespip install -e .to break givensetuptools>60build requirement pulls setuptools 82+. While a plausible fix is to setup a constraint like,<82, I thought it'd be better to move to usepackaginggiven the purposepkg_resourceswas being used for (version checking) to avoid constraining downstream builders.I also made sure the Cython versions were aligned to
~=3.1, seems like misalignment was introduced after #693Disclosure (because this seems needed nowadays): This PR is made by human-only contribution without AI usage.
Closes #729