MDEV-38202: add init_rpl_role in SHOW VARIABLES#4904
Open
Mahmoud-kh1 wants to merge 1 commit intoMariaDB:mainfrom
Open
MDEV-38202: add init_rpl_role in SHOW VARIABLES#4904Mahmoud-kh1 wants to merge 1 commit intoMariaDB:mainfrom
Mahmoud-kh1 wants to merge 1 commit intoMariaDB:mainfrom
Conversation
Mahmoud-kh1
force-pushed
the
init_rpl_role
branch
5 times, most recently
from
bcb64ce to
f6f6a30
Compare
…-only sys_var set at server startup
Mahmoud-kh1
force-pushed
the
init_rpl_role
branch
from
f6f6a30 to
029860e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to see the server’s initial replication role.
I done this by introducing a new global system variable and make it catch the value of rpl_status at the startup and never changed by making it read-only.
Reason
Previously,
init_rpl_rolecould be set in the cnf file but was not visible inSHOW VARIABLESwhich will be helpful for investigating issues as it will allow us to see with which value mariadb was started.Tests :
Added basic tests to verify that
init_rpl_roleis correctly set at startup and displayed properly.