Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Multiword tokens? More like multiword brokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current release, multiword distillation is gone. Any multi-word tokens just get removed from the vocabulary, i.e., nothing breaks or is broken, users are just not able to add multi-word tokens.
This PR fixes that. The issue was that we add multiword tokens as added tokens, but call
prune_added_tokensafter adding the tokens. We need to callprune_added_tokensto get rid of broken EOS/BOS tokens in some tokenizers. This slipped past unit testing coverage because we did not have an end to end test with multiword units, and the test that tested multiword units only covered the actual creation of the vocabulary.I backported the test to main, and saw it failed there. So the added test is a test of the issue we're solving.