Refactor after merge 1258 into E

[milov-dmitriy]

No description provided.

[Copilot]

Pull request overview

This PR aligns LDAP schema/setup data and tests after a merge by normalizing user identifiers/domains, tightening ACL evaluation, and refactoring schema directory creation DTO naming/usage.

Changes:

• Updated test fixtures and assertions to use @md.test for UPN/mail and adjusted WhoAmI expectations accordingly.
• Refactored LDAP schema directory-creation DTO from CreateDirDTO to DirCreateDTO and improved ObjectClass creation attribute assembly (including correct KindType serialization).
• Fixed/clarified schema-related error messages and made initial configuration directory seed data consistent (avoiding duplicate/invalid objectClass values).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/test_ldap/test_util/test_modify.py	Updates expected user mail to user0@md.test.
tests/test_ldap/test_ldap3_whoami.py	Updates WhoAmI assertion to return u:user0@md.test.
tests/constants.py	Updates seeded test user UPN/mail values and fixes configuration directory seed object_class / objectClass composition.
app/ldap_protocol/roles/access_manager.py	Removes unsafe type: ignore path and makes invalid ACE states explicit.
app/ldap_protocol/ldap_schema/raw_definition_parser.py	Fixes incorrect ValueError message for missing object class name.
app/ldap_protocol/ldap_schema/object_class/object_class_use_case.py	Uses DirCreateDTO, builds attributes list more cleanly, and stores KindType via .value.
app/ldap_protocol/ldap_schema/exceptions.py	Corrects ObjectClassNotSetKindError docstring to match behavior.
app/ldap_protocol/ldap_schema/entity_type/entity_type_use_case.py	Improves error messaging when updating a non-existent entity type.
app/ldap_protocol/ldap_schema/dto.py	Renames CreateDirDTO to DirCreateDTO.
app/ldap_protocol/ldap_schema/directory_create_use_case.py	Updates imports/signature to DirCreateDTO.
app/ldap_protocol/ldap_schema/attribute_type/attribute_type_use_case.py	Updates imports/usage to DirCreateDTO.
app/constants.py	Fixes configuration directory seed object_class / objectClass to avoid invalid/duplicate values.
app/alembic/versions/708b01eaf025_convert_schema_to_ldap.py	Updates imports/usage to DirCreateDTO.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.