FIX #408 Hide location row when no location @ashishxdev#430
Open
ashishxdev wants to merge 4 commits intoNextCommunity:mainfrom
Open
FIX #408 Hide location row when no location @ashishxdev#430ashishxdev wants to merge 4 commits intoNextCommunity:mainfrom
ashishxdev wants to merge 4 commits intoNextCommunity:mainfrom
Conversation
ashishxdev
commented
Apr 4, 2026
There was a problem hiding this comment.
Code Review
This pull request removes libc constraints from the package-lock.json and updates the location display logic in the Nunjucks templates. Feedback for src/_includes/bio.njk suggests simplifying the redundant conditional logic and addressing potential whitespace issues in the HTML output by using a more concise template structure and the trim filter for consistency.
src/_includes/bio.njk
Outdated
Comment on lines
+25
to
+32
| {% if location %} | ||
| <div class="flex items-center gap-3"> | ||
| <span class="text-lg">📍</span> | ||
| <span class="text-[var(--text-muted)]">{{ location }}{% if country %}, {{ country }}{% endif %}</span> | ||
| <span class="text-[var(--text-muted)]"> | ||
| {% if location and country %}{{ location }}, {{ country }}{% elif location %}{{ location }}{% endif %} | ||
| </span> | ||
| </div> | ||
| {% endif %} |
There was a problem hiding this comment.
The logic for displaying the location has been made unnecessarily complex and introduces potential UI issues due to whitespace handling.
- Redundancy: The nested
if/elifchecks forlocationare redundant because the entire block is already guarded by{% if location %}. The previous logic was more concise and readable. - Whitespace Sensitivity: In HTML, newlines and indentation inside a
<span>are rendered as spaces. The current multi-line structure will likely result in unwanted leading and trailing whitespace around the location text. - Consistency: It is recommended to use
| trimto ensure that strings containing only whitespace are correctly identified as empty, matching the logic applied insrc/index.njk.
{% if location and location | trim %}
<div class="flex items-center gap-3">
<span class="text-lg">📍</span>
<span class="text-[var(--text-muted)]">{{ location }}{% if country %}, {{ country }}{% endif %}</span>
</div>
{% endif %}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.