Fix NPE in setHeldItemSlot and clarify empty catches in SimpleServiceManager#13711
Closed
Ak-dude wants to merge 1 commit intoPaperMC:mainfrom
Closed
Fix NPE in setHeldItemSlot and clarify empty catches in SimpleServiceManager#13711Ak-dude wants to merge 1 commit intoPaperMC:mainfrom
Ak-dude wants to merge 1 commit intoPaperMC:mainfrom
Conversation
…sManager - Add null checks for holder and connection in CraftInventoryPlayer#setHeldItemSlot, matching the existing pattern in setItem() to prevent NPE when called on a disconnecting player - Replace silent empty catch blocks in SimpleServicesManager with explanatory comments describing why NoSuchElementException is swallowed
Ak-dude
force-pushed
the
fix/null-checks-and-empty-catches
branch
from
0075df2 to
72cb766
Compare
Author
|
hello? |
Member
|
Thank you for your pull request! However, we are not accepting pull requests that generally change random documentation. And your bug fix doesnt exactly make sense, connection is never set to null on disconnection. In the future, we recommend you look at github issues for what may be appropriate to pull request. 😄 |
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would love feedback!