Skip to content

4.x: Detect un-awaited CompletionStageDisposables during tests#8093

Merged
akarnokd merged 2 commits intoReactiveX:4.xfrom
akarnokd:CleanerDetectUnusedReturnHMS
Apr 3, 2026
Merged

4.x: Detect un-awaited CompletionStageDisposables during tests#8093
akarnokd merged 2 commits intoReactiveX:4.xfrom
akarnokd:CleanerDetectUnusedReturnHMS

Conversation

@akarnokd
Copy link
Copy Markdown
Member

@akarnokd akarnokd commented Apr 3, 2026

Adds a tracking mechanism to track CompositeStageDisposables which are never await() 'd or ignore()'d or close()'d.

Mainly test time verification.

The trouble is that if they escape the executorservice scope, it can interrupt the unit test unexpectedly and result in failed tests due to operator bugs.

The error stacktrace will point at the test and where the CSD was allocated in the code.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java: 4.818
src/main/java/io/reactivex/rxjava4/core/Flowable.java: 4.779
src/main/java/io/reactivex/rxjava4/core/Scheduler.java: 4.547
src/main/java/io/reactivex/rxjava4/core/Streamable.java: 4.517
src/main/java/io/reactivex/rxjava4/core/Streamer.java: 4.517
src/main/java/io/reactivex/rxjava4/core/VirtualEmitter.java: 4.833
src/main/java/io/reactivex/rxjava4/core/VirtualTransformer.java: 4.852
src/main/java/io/reactivex/rxjava4/disposables/CompositeDisposable.java: 4.279
src/main/java/io/reactivex/rxjava4/disposables/DisposableContainer.java: 4.437
src/main/java/io/reactivex/rxjava4/functions/Consumer3.java: 4.910
src/main/java/io/reactivex/rxjava4/internal/disposables/ListCompositeDisposable.java: 4.072
src/main/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableEmpty.java: 4.851
src/main/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableFromPublisher.java: 4.459
src/main/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableJust.java: 4.494
src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.461
src/main/java/io/reactivex/rxjava4/internal/virtual/FlowableVirtualCreateExecutor.java: 4.452
src/main/java/io/reactivex/rxjava4/internal/virtual/FlowableVirtualTransformExecutor.java: 4.140
src/test/java/io/reactivex/rxjava4/completable/CompletableIsolatedTest.java: 4.785
src/test/java/io/reactivex/rxjava4/completable/CompletableTest.java: 4.435
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java: 4.665

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/core/CompletionStageDisposable.java: 4.818
src/main/java/io/reactivex/rxjava4/core/Flowable.java: 4.779
src/main/java/io/reactivex/rxjava4/core/Scheduler.java: 4.547
src/main/java/io/reactivex/rxjava4/core/Streamable.java: 4.517
src/main/java/io/reactivex/rxjava4/core/Streamer.java: 4.517
src/main/java/io/reactivex/rxjava4/core/VirtualEmitter.java: 4.833
src/main/java/io/reactivex/rxjava4/core/VirtualTransformer.java: 4.852
src/main/java/io/reactivex/rxjava4/disposables/CompositeDisposable.java: 4.279
src/main/java/io/reactivex/rxjava4/disposables/DisposableContainer.java: 4.437
src/main/java/io/reactivex/rxjava4/functions/Consumer3.java: 4.910
src/main/java/io/reactivex/rxjava4/internal/disposables/ListCompositeDisposable.java: 4.072
src/main/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableEmpty.java: 4.851
src/main/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableFromPublisher.java: 4.459
src/main/java/io/reactivex/rxjava4/internal/operators/streamable/StreamableJust.java: 4.494
src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.461
src/main/java/io/reactivex/rxjava4/internal/virtual/FlowableVirtualCreateExecutor.java: 4.452
src/main/java/io/reactivex/rxjava4/internal/virtual/FlowableVirtualTransformExecutor.java: 4.140
src/test/java/io/reactivex/rxjava4/completable/CompletableIsolatedTest.java: 4.785
src/test/java/io/reactivex/rxjava4/completable/CompletableTest.java: 4.435
src/test/java/io/reactivex/rxjava4/internal/operators/flowable/FlowableReplayEagerTruncateTest.java: 4.665

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.90%. Comparing base (73241eb) to head (aedc4b3).
⚠️ Report is 1 commits behind head on 4.x.

Files with missing lines Patch % Lines
...ctivex/rxjava4/core/CompletionStageDisposable.java 73.33% 6 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (73.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8093      +/-   ##
============================================
- Coverage     98.94%   98.90%   -0.05%     
- Complexity     6863     6867       +4     
============================================
  Files           767      767              
  Lines         48557    48586      +29     
  Branches       6506     6508       +2     
============================================
+ Hits          48047    48052       +5     
- Misses          388      397       +9     
- Partials        122      137      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit d9d985c into ReactiveX:4.x Apr 3, 2026
5 of 6 checks passed
@akarnokd akarnokd deleted the CleanerDetectUnusedReturnHMS branch April 3, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant