Skip to content

BUG: Remove duplicate controller process#949

Merged
MateusStano merged 2 commits intoRocketPy-Team:developfrom
zuorenchen:bug/DuplicateControllerProcess
Apr 4, 2026
Merged

BUG: Remove duplicate controller process#949
MateusStano merged 2 commits intoRocketPy-Team:developfrom
zuorenchen:bug/DuplicateControllerProcess

Conversation

@zuorenchen
Copy link
Copy Markdown
Contributor

@zuorenchen zuorenchen commented Apr 4, 2026

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

#948 BUG: Controller processed twice in flight.py

New behavior

  1. Remove duplicate process
  2. Fix the condition for sensor measurement. Should check if the sensor exists in the time_node instead of flight.sensor

Breaking change

  • No

Additional information

image image

@zuorenchen zuorenchen requested a review from a team as a code owner April 4, 2026 10:43
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.05%. Comparing base (9cf3dd4) to head (b23ab58).
⚠️ Report is 50 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #949      +/-   ##
===========================================
+ Coverage    80.27%   81.05%   +0.78%     
===========================================
  Files          104      107       +3     
  Lines        12769    13903    +1134     
===========================================
+ Hits         10250    11269    +1019     
- Misses        2519     2634     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great catch!

@MateusStano MateusStano added Bug Something isn't working Controllers Controlling rocket flight methods labels Apr 4, 2026
@MateusStano MateusStano merged commit de29100 into RocketPy-Team:develop Apr 4, 2026
10 checks passed
@zuorenchen zuorenchen deleted the bug/DuplicateControllerProcess branch April 5, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Controllers Controlling rocket flight methods

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants