fix: surface crawler find_by_purls errors instead of swallowing#55
Open
Wenxin-Jiang wants to merge 1 commit intomainfrom
Open
fix: surface crawler find_by_purls errors instead of swallowing#55Wenxin-Jiang wants to merge 1 commit intomainfrom
Wenxin-Jiang wants to merge 1 commit intomainfrom
Conversation
Replace all `if let Ok(packages) = crawler.find_by_purls(...)` with `match` blocks that log warnings on Err when not in silent mode. Previously, per-path crawler failures (corrupt manifests, permission denied, etc.) were silently dropped, causing packages to vanish from discovery without any diagnostic output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@claude review once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if let Ok(packages) = crawler.find_by_purls(...)withmatchblocks that log warnings to stderr on error.find_packages_for_purls(used by apply) andfind_packages_for_rollback(used by rollback).get_node_modules_paths()) were already handled correctly and left unchanged.Addresses finding HIGH-3 (crawler
find_by_purlserrors silently swallowed), which feeds into the critical silent-no-op problem when crawler failures reduce the discovered package set to zero.Test plan
cargo check -p socket-patch-clicompilescargo test -p socket-patch-clipassespackage.jsoninnode_modules/, runapply— should see warning about failed scan--silent— warning should be suppressed🤖 Generated with Claude Code