Skip to content

chore: update to TS6.0, fix deprecated tsconfig options #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camc314 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update to TS6.0, fix deprecated tsconfig options #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa6b68e
fix: upgrade TypeScript, remove deprecated `baseUrl`
camc314 Apr 2, 2026
2665f58
u
camc314 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli-aliases/create-start-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
4 changes: 2 additions & 2 deletions cli-aliases/create-start-app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node"
"moduleResolution": "NodeNext"
},
"include": ["./src/**/*.ts"],
"exclude": ["node_modules", "dist"]
Expand Down
2 changes: 1 addition & 1 deletion cli-aliases/create-tanstack-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
4 changes: 2 additions & 2 deletions cli-aliases/create-tanstack-app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node"
"moduleResolution": "NodeNext"
},
"include": ["./src/**/*.ts"],
"exclude": ["node_modules", "dist"]
Expand Down
2 changes: 1 addition & 1 deletion cli-aliases/create-tanstack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
4 changes: 2 additions & 2 deletions cli-aliases/create-tanstack/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node"
"moduleResolution": "NodeNext"
},
"include": ["./src/**/*.ts"],
"exclude": ["node_modules", "dist"]
Expand Down
2 changes: 1 addition & 1 deletion cli-aliases/create-tsrouter-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
4 changes: 2 additions & 2 deletions cli-aliases/create-tsrouter-app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node"
"moduleResolution": "NodeNext"
},
"include": ["./src/**/*.ts"],
"exclude": ["node_modules", "dist"]
Expand Down
2 changes: 1 addition & 1 deletion cli-aliases/ts-create-start/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
4 changes: 2 additions & 2 deletions cli-aliases/ts-create-start/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node"
"moduleResolution": "NodeNext"
},
"include": ["./src/**/*.ts"],
"exclude": ["node_modules", "dist"]
Expand Down
2 changes: 1 addition & 1 deletion examples/custom-cli/create-qwik-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
2 changes: 1 addition & 1 deletion examples/custom-cli/create-qwik-app/project/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"eslint": "8.57.0",
"eslint-plugin-qwik": "^1.13.0",
"prettier": "3.3.3",
"typescript": "5.4.5",
"typescript": "6.0.2",
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

What is the latest stable version of TypeScript 6.0.x and are there any known critical issues with TypeScript 6.0.2?

💡 Result:

The latest stable version of TypeScript in the 6.0.x series is 6.0.2, released on March 23, 2026. There are no known critical issues with 6.0.2; it is presented as the stable final release following beta (6.0.0) and RC (6.0.1). Some minor bugs have been reported post-release (e.g., type inference regression in #63309), but none are identified as critical, and the release notes emphasize stability as a bridge to 7.0.

Citations:

🏁 Script executed:

#!/bin/bash
# Search for all TypeScript version declarations in package.json files
rg --type json -n '"typescript":\s*"' -g 'package.json'

Repository: TanStack/cli

Length of output: 1481

Update TypeScript version to use caret range for consistency.

examples/custom-cli/create-qwik-app/project/base/package.json specifies 6.0.2 (exact version), while all other package.json files in the PR use ^6.0.2 (caret range). Change to ^6.0.2 to align with the rest of the codebase.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@examples/custom-cli/create-qwik-app/project/base/package.json` at line 35,
The TypeScript dependency in
examples/custom-cli/create-qwik-app/project/base/package.json is pinned to an
exact version ("typescript": "6.0.2"); change it to a caret range ("^6.0.2") so
it matches other package.json files—locate the "typescript" entry in that
package.json and update the version string to include the caret.

Copy link
Copy Markdown
Author

@camc314 camc314 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not deliberate - this previously specified an exact version, so i followed that pattern

Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camc314 That makes sense — the file had a pre-existing convention of pinning to an exact version (5.4.5), and you preserved that pattern. The inconsistency predates this PR, so it's reasonable to keep it as-is. No change needed.

🧠 Learnings used 
Learnt from: CR
Repo: TanStack/cli PR: 0
File: examples/solid/blog/.cursorrules:0-0
Timestamp: 2026-03-31T02:17:45.537Z
Learning: Applies to examples/solid/blog/**/*.{ts,tsx} : Implement strict TypeScript checks

"undici": "*",
"vite": "^7.1.7",
"vite-tsconfig-paths": "^4.2.1"
Expand Down
2 changes: 1 addition & 1 deletion examples/custom-cli/create-qwik-app/project/packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"typescript": {
"devDependencies": {
"typescript": "^5.7.2"
"typescript": "^6.0.2"
}
},
"tailwindcss": {
Expand Down
5 changes: 3 additions & 2 deletions examples/custom-cli/create-qwik-app/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "bundler",
"moduleResolution": "NodeNext",
"types": ["node"],
"declaration": true,
"declarationDir": "./dist/types"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/custom-cli/create-rwsdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
2 changes: 1 addition & 1 deletion examples/custom-cli/create-rwsdk/project/base/package.json.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@types/react": "19.1.2",
"@types/react-dom": "19.1.2",
"tailwindcss": "^4.1.14",
"typescript": "5.8.3",
"typescript": "6.0.2",
"vite": "7.1.6",
"wrangler": "4.38.0"
},
Expand Down
5 changes: 3 additions & 2 deletions examples/custom-cli/create-rwsdk/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "bundler",
"moduleResolution": "NodeNext",
"types": ["node"],
"declaration": true,
"declarationDir": "./dist/types"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/custom-cli/customized-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
},
"devDependencies": {
"@types/node": "^22.13.4",
"typescript": "^5.6.3"
"typescript": "^6.0.2"
}
}
5 changes: 3 additions & 2 deletions examples/custom-cli/customized-react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{
"compilerOptions": {
"target": "ES2020",
"module": "ES2020",
"module": "NodeNext",
"outDir": "./dist",
"rootDir": "./src",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"moduleResolution": "bundler",
"moduleResolution": "NodeNext",
"types": ["node"],
"declaration": true,
"declarationDir": "./dist/types"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/react/blog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@vitejs/plugin-react": "^5.0.4",
"jsdom": "^27.0.0",
"remark-gfm": "^4.0.1",
"typescript": "^5.7.2",
"typescript": "^6.0.2",
"vite": "^7.1.7",
"vite-tsconfig-paths": "^5.1.4",
"vitest": "^3.0.5",
Expand Down
4 changes: 2 additions & 2 deletions examples/react/blog/starter.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions examples/react/blog/template.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion examples/react/blog/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"target": "ES2022",
"jsx": "react-jsx",
"module": "ESNext",
"baseUrl": ".",
"paths": {
"#/*": ["./src/*"],
"content-collections": ["./.content-collections/generated"],
Expand Down
2 changes: 1 addition & 1 deletion examples/react/ecommerce/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@types/react-dom": "^19.2.0",
"@vitejs/plugin-react": "^5.0.4",
"jsdom": "^27.0.0",
"typescript": "^5.7.2",
"typescript": "^6.0.2",
"vite": "^7.3.1",
"vitest": "^3.0.5",
"web-vitals": "^5.1.0"
Expand Down
Loading
Loading