Skip to content

fix(eslint): add eslint package to ESLint toolchain devDependencies #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gs0428 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

fix(eslint): add eslint package to ESLint toolchain devDependencies #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/create/src/frameworks/react/toolchains/eslint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
},
"devDependencies": {
"@tanstack/eslint-config": "latest",
"eslint": "^9.20.0",
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify ESLint is declared in both framework ESLint toolchains
fd -a package.json packages/create/src/frameworks | grep '/toolchains/eslint/package.json$' \
  | xargs -I{} sh -c 'echo "==> {}"; jq -r ".devDependencies.eslint // \"missing\"" "{}"'

# Verify the peer range in lockfile still accepts ESLint 9.x
rg -n -C2 'eslint:\s*\^8\.0\.0 \|\| \^9\.0\.0' pnpm-lock.yaml

Repository: TanStack/cli

Length of output: 389

🌐 Web query:

ESLint 9.20.0 Node.js minimum version compatibility

💡 Result:

ESLint 9.20.0 requires Node.js ^18.18.0 or higher. The v9 series initially supported Node.js 18.18.0+, as confirmed for early v9 releases. The requirement was updated later in the v9 series (after September 2025, via PR #20160) to ^20.19.0 || ^22.13.0 || >=24, dropping Node.js 18 support, but this change occurred after the 9.20.0 release on February 7, 2025. Release notes, changelog, and npm page for 9.20.0 do not mention a Node version change.

Citations:

🏁 Script executed:

cat -n packages/create/src/frameworks/react/toolchains/eslint/package.json

Repository: TanStack/cli

Length of output: 389

Node.js compatibility issue: Update template's minimum Node.js version to match ESLint 9.20.0 requirement.

The React ESLint toolchain correctly declares "eslint": "^9.20.0". However, ESLint 9.20.0 requires Node.js ^18.18.0, but the template's engines field specifies only >=18, which would allow Node.js 18.0.0–18.17.x where ESLint 9.20.0 won't run. Update the template's Node.js minimum to >=18.18.0 to ensure compatibility.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/create/src/frameworks/react/toolchains/eslint/package.json` at line
9, The package.json currently pins "eslint": "^9.20.0" but the template's
engines.node allows ">=18", which is too low for ESLint 9.20.0; update the
package.json engines.node value (the "engines" / "engines.node" field) to
">=18.18.0" so the template's minimum Node.js matches ESLint 9.20.0's
requirement and prevents installing on unsupported Node versions.

"prettier": "^3.8.1"
}
}
1 change: 1 addition & 0 deletions packages/create/src/frameworks/solid/toolchains/eslint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
},
"devDependencies": {
"@tanstack/eslint-config": "latest",
"eslint": "^9.20.0",
"prettier": "^3.8.1"
}
}