fix: prevent exitChan blocking in websocket mode#399
Open
chenhang233 wants to merge 1 commit intoaceld:masterfrom
Open
fix: prevent exitChan blocking in websocket mode#399chenhang233 wants to merge 1 commit intoaceld:masterfrom
chenhang233 wants to merge 1 commit intoaceld:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
通过退出信号试图停止进程,发现一直阻塞到超时.
关闭的 channel 会立即让所有阻塞的 <-ch 操作返回零值. t.exitChan <- struct{}{} 是多余的.
如果只启动websocket模式:
没有 goroutine 在执行 <-s.exitChan
s.exitChan <- struct{}{} 永久阻塞