Skip to content

Update labels on ScaleSet and Runners#4426

Open
pauloconnor wants to merge 1 commit intoactions:masterfrom
pauloconnor:fix_labels
Open

Update labels on ScaleSet and Runners#4426
pauloconnor wants to merge 1 commit intoactions:masterfrom
pauloconnor:fix_labels

Conversation

@pauloconnor
Copy link
Copy Markdown

This should address #4424 and #4425

@nikola-jokic
Copy link
Copy Markdown
Collaborator

I'm not sure if strings.Join on labels is the right thing to do to set the labels, because the combination of labels joined with "," must have less than 64 characters.

Valid label value:
must be 63 characters or less (can be empty),
unless empty, must begin and end with an alphanumeric character ([a-z0-9A-Z]),
could contain dashes (-), underscores (_), dots (.), and alphanumerics between.

We can set the annotation on these resources, because it doesn't have such restrictions as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants