Open
Conversation
Files mainly copied from nuxt2 version
adriancuadrado
suggested changes
May 25, 2025
| const SUPPORTED_GENERATORS = ['next', 'nuxt', 'gatsby', 'sveltekit'] | ||
| const SUPPORTED_FILE_EXTENSIONS = ['.js', '.cjs', '.mjs'] | ||
| const SUPPORTED_GENERATORS = ['next', 'nuxt', 'nuxt3', 'gatsby', 'sveltekit'] | ||
| const SUPPORTED_FILE_EXTENSIONS = ['.js', '.cjs', '.mjs', '.ts'] |
There was a problem hiding this comment.
This change will break Nextjs builds that make use of Typescript in its config with next.config.ts files. This is because the project uses espree to read and parse and modify configuration files and espree doesn't support typescript files. Besides, shouldn't this problem also happen with nuxt? I haven't checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to allow Nuxt3's config file
nuxt.config.ts. However, it uses Typescript, which looks like not being supported by now.I've completed the function and test. If there's anything I should modify, please let me know!
As TypeScript files aren't really supported (say if you write
as NuxtConfigat the end, it's not going to recognize your config), I'm not modifying SUPPORTED_FILE_EXTENSIONS in set-pages-config.js. However, there's a need to modify those in other files for usual configs to work.So, what is a currently accepted one? Well, if we type only key and values and don't write any type annotations, it's going to be fine.
Althought this may sounds silly since we are losing a huge functionality of TypeScript, I believe that kind of usage is really rare.
close #74