[FLINK-39388][tests] Fix flaky DataGeneratorSourceITCase#testGatedRateLimiter#27883
Open
featzhang wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39388][tests] Fix flaky DataGeneratorSourceITCase#testGatedRateLimiter#27883featzhang wants to merge 1 commit intoapache:masterfrom
featzhang wants to merge 1 commit intoapache:masterfrom
Conversation
…ckpointListener to stop collecting after first checkpoint completes
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR fixes the flaky test
DataGeneratorSourceITCase#testGatedRateLimiterby eliminating a race condition in theFirstCheckpointFilterinner class.The root cause is that
FirstCheckpointFilterpreviously stopped collecting elements insidesnapshotState(). However, the checkpoint barrier can arrive atFirstCheckpointFilterbefore all upstream elements (emitted in the same checkpoint cycle byGatedRateLimiter) have been processed, causing the filter to prematurely discard elements and making the assertionassertThat(results).hasSize(capacityPerCheckpoint)fail non-deterministically.Fixes: FLINK-39388
Brief change log
DataGeneratorSourceITCase: RefactoredFirstCheckpointFilterto implementCheckpointListenerin addition toCheckpointedFunction. The element cutoff logic is moved fromsnapshotState()tonotifyCheckpointComplete(), ensuring that collection stops only after the first checkpoint has fully completed and all in-flight elements have been processed downstream.Verifying this change
This change is a test-only fix. The existing assertion
assertThat(results).hasSize(capacityPerCheckpoint)continues to validate the correctness ofGatedRateLimiter. The fix eliminates the non-deterministic timing window that caused intermittent failures.Does this pull request potentially affect one of the following parts?
@Public(Evolving): NoDocumentation