fix(security): add 5-second execution timeout for custom access token scripts#571
Merged
lakhansamani merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
… scripts The CustomAccessTokenScript executed in Otto JS VM had no timeout, allowing malicious or buggy scripts (e.g., infinite loops) to cause CPU exhaustion / DoS. This adds a 5-second timeout using Otto's vm.Interrupt channel, with proper goroutine cleanup to prevent leaks. Both call sites (CreateAccessToken and CreateIDToken) are consolidated into a single runCustomAccessTokenScript helper method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runCustomAccessTokenScripthelper used by bothCreateAccessTokenandCreateIDTokenvm.Interruptchannel with a goroutine timer;donechannel prevents goroutine leaksFiles Changed
internal/token/auth_token.go— extracted helper with timeout mechanismTest plan
make test-sqlitepasses (no regressions)