fix(security): reduce cookie max-age, sanitize errors, replace panic with error#575
Merged
lakhansamani merged 1 commit intomainfrom Apr 5, 2026
Merged
fix(security): reduce cookie max-age, sanitize errors, replace panic with error#575lakhansamani merged 1 commit intomainfrom
lakhansamani merged 1 commit intomainfrom
Conversation
…e panic with error return - Session cookie max-age reduced from 1 year to 24 hours to match server-side session expiry - Error messages in verify_email, reset_password, and verify_otp no longer leak internal error details - GenerateOTP now returns (string, error) instead of panicking on crypto/rand failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerateOTP()fromstringto(string, error)return, replacingpanic()with proper error propagation; updated all 4 callersFiles Changed
internal/cookie/cookie.go— max-age reductioninternal/graphql/verify_email.go— generic error messagesinternal/graphql/reset_password.go— generic error messagesinternal/graphql/verify_otp.go— generic error messagesinternal/utils/generate_otp.go— return error instead of panicinternal/graphql/login.go,signup.go,resend_otp.go,forgot_password.go— handle OTP errorTest plan
make test-sqlitepasses (no regressions)