Skip to content

fix(ci): resolve security audit job failure#44

Merged
bashandbone merged 5 commits intomainfrom
copilot/fix-security-audit-issues
Apr 4, 2026
Merged

fix(ci): resolve security audit job failure#44
bashandbone merged 5 commits intomainfrom
copilot/fix-security-audit-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

The Security Audit CI job was failing with Resource not accessible by integration because rustsec/audit-check@v1.4.1 needs checks: write to post Check Run annotations — the job had no permissions block. Additionally, RUSTSEC-2024-0436 (paste unmaintained) was surfacing as an unhandled advisory.

Changes

  • .github/workflows/ci.yml

    • Add permissions: checks: write + contents: read to security_audit job
    • Add RUSTSEC-2024-0436 to rustsec/audit-check ignore list
    • Align actions/checkout to @v4 (was @v6, inconsistent with rest of workflow)
  • deny.toml

    • Add RUSTSEC-2024-0436 to [advisories] ignore with rationale comment

paste is an informational-only (unmaintained, no CVE) transitive dep via gixcurl-sysrustls-ffimacro_rules_attributepaste. No patched version exists; ignoring is appropriate.

Original prompt

Please review the failing CI action (looks like security audit fail). Assess the security issue and determine what we should do about it. If you update or change dependencies please ensure all associated functionality and tests continue to run/pass as expected


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

…and ignore paste advisory

Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bashandbone/submod/sessions/c20905af-2852-47a7-9a49-a6f428e19086
Copilot AI changed the title [WIP] Fix security audit failures in CI actions fix(ci): resolve security audit job failure Mar 24, 2026
Copilot AI requested a review from bashandbone March 24, 2026 23:00
@bashandbone bashandbone marked this pull request as ready for review April 4, 2026 03:26
Copilot AI review requested due to automatic review settings April 4, 2026 03:26
@bashandbone bashandbone added the dependencies Pull requests that update a dependency file label Apr 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the failing Security Audit CI job by granting the minimal GitHub token permissions needed for rustsec/audit-check to publish Check Run annotations, and suppressing a newly surfaced RustSec advisory that has no available patched version.

Changes:

  • Add job-level permissions (checks: write, contents: read) to the security_audit job to resolve Resource not accessible by integration.
  • Ignore RUSTSEC-2024-0436 in the rustsec/audit-check workflow configuration and in deny.toml.
  • Switch security_audit’s actions/checkout usage to @v4.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/ci.yml Grants required token permissions for audit annotations and updates the audit ignore list used by the CI security audit job.
deny.toml Keeps cargo-deny advisory handling aligned with CI by ignoring RUSTSEC-2024-0436 with rationale.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 76 to 77
- uses: actions/checkout@v4
- uses: rustsec/audit-check@v1.4.1
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow still contains other actions/checkout@v6 usages (e.g., the coverage job later in this same file). If the intent is to standardize on v4 (as in test and security_audit), update those remaining occurrences as well to avoid inconsistent behavior across jobs (and potential failures if the major version differs).

Copilot uses AI. Check for mistakes.
Comment on lines 78 to +80
with:
token: ${{ secrets.GITHUB_TOKEN }}
ignore: RUSTSEC-2024-0364
ignore: RUSTSEC-2024-0364,RUSTSEC-2024-0436
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustsec/audit-check is configured to ignore RUSTSEC-2024-0436 here, but the repo also has an audit.toml (used for cargo audit) that currently only ignores RUSTSEC-2024-0364. Consider adding RUSTSEC-2024-0436 to audit.toml too so local cargo audit runs and any future CI usage of the config file stay consistent with this workflow ignore list.

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bashandbone bashandbone requested a review from Copilot April 4, 2026 03:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bashandbone bashandbone merged commit eed6371 into main Apr 4, 2026
7 checks passed
@bashandbone bashandbone deleted the copilot/fix-security-audit-issues branch April 4, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants