Added support for input devices/streams and tests#178
Added support for input devices/streams and tests#178Omar-Riaz wants to merge 2 commits intobramp:masterfrom
Conversation
|
Updated test to support device_number. Is it ok to include the parameter if there are no duplicates and it is set to zero? |
|
Thanks for the PR. I'm on vacation for the next week, so I won't look at this until later next week. Feel free to ping me if I don't respond next week. |
|
Hi @bramp , did you get a chance to review? |
|
Hi @Omar-Riaz, thank you for this long-standing PR! We are currently modernizing the library's builder architecture and have decided to implement support for input devices/streams using a new architectural approach based on your foundation. We will be creating a specialized |
I created a subclass called
FFMpegInputBuilderwhich extends theAbstractFFmpegStreamBuilder. Seeing that theAbstractFFmpegInputBuilderwas designed for outputs, I re-implemented the filename property and build method to retain all previous functionality.I also added tests to see that the inputs are built properly, modelled after #156 . I added a convenience method to parse commands separated by spaces for assertion purposes.
From the
FFmpegBuilder, you simply calladdInputStream(String inputStream)to build the input.