Open
Conversation
Contributor
Author
|
Tests depend on upstream. Will rerun when merged. |
alexcrichton
reviewed
Apr 3, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! This'll unfortunately have to wait until Wasmtime 44 is released since there's no easy way to pull in the dev binaries here for the time being. Mind adding some tests though which mostly just call the methods and ensure everything's wired up correctly? No need for a full end-to-end test as that'd be a pretty gnarly *.wat.
chaynabors
force-pushed
the
add-wasi-http
branch
from
53707f3 to
b030baa
Compare
Contributor
Author
|
Added tests and ran against my local build. Happy to wait since team has access to a release in my fork that I'm pointing at. |
alexcrichton
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on bytecodealliance/wasmtime#12950 which adds wasmtime_component_linker_add_wasi_http and wasmtime_context_set_wasi_http to the C API.
Adds linker.add_wasi_http() and store.set_wasi_http() following the same pattern as add_wasip2 and set_wasi. _bindings.py was regenerated with cbindgen.py against the updated C headers.