You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This pull request introduces a new packages/shared/src/types/enums.ts module that exports two as const enum-like objects for OAuth configuration: OAuthProviderEnum (mapping provider names to identifiers like 'linkedin_oidc', 'x') and OAuthStrategyEnum (mapping the same keys to Clerk-style strategy strings like 'oauth_google', 'oauth_linkedin_oidc'). Corresponding TypeScript union types are exported, derived from these enums and validated against existing OAuthProvider and OAuthStrategy types. The central types index file is updated to re-export all exports from the new enums module.
The title 'Add enum helpers to improve UX' directly corresponds to the main change: introducing OAuthProviderEnum and OAuthStrategyEnum to replace magic strings with type-safe enum objects.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Add type-safe enum objects to
@clerk/sharedfor OAuth providers and strategies, eliminating magic strings in user code.Changes
OAuthProviderEnum- camelCased keys mapping to provider namesOAuthStrategyEnum- camelCased keys mapping to Clerk'soauth_${provider}strategy format@clerk/shared/typesChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change