fix: resolve knip false positives blocking pre-commit hook#249
Open
jamesbroadhead wants to merge 1 commit intodatabricks:mainfrom
Open
fix: resolve knip false positives blocking pre-commit hook#249jamesbroadhead wants to merge 1 commit intodatabricks:mainfrom
jamesbroadhead wants to merge 1 commit intodatabricks:mainfrom
Conversation
…cies knip doesn't trace CSS @import directives or files in ignored directories, causing false positives for: - globals.css (used by build config and package exports) - tailwindcss/tw-animate-css (imported in globals.css) - json-schema-to-typescript (used in tools/generate-schema-types.ts) Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knipcheck in the pre-commit hook fails on every commit due to false positivesglobals.cssis reported as unused (knip doesn't trace CSS files, but it's used by build config and package exports)tailwindcssandtw-animate-cssare reported as unused devDeps (imported via CSS@importin globals.css)json-schema-to-typescriptis reported as unused (used intools/generate-schema-types.ts, buttools/**is in knip's file ignore list)knip.jsonfor all four false positivesTest plan
pnpm knippasses cleanly after the changeThis pull request was AI-assisted by Isaac.