Exit with error when the --batch argument is an empty string#1808
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Exit with error when the --batch argument is an empty string#1808rolandwalker wants to merge 1 commit intomainfrom
--batch argument is an empty string#1808rolandwalker wants to merge 1 commit intomainfrom
Conversation
rather than silently ignoring --batch and entering the REPL. We must use a None test rather than a general truthiness test.
rolandwalker
force-pushed
the
RW/respect-empty-batch-argument
branch
from
a7afaee to
4e34a80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exit with error when the
--batchargument is an empty string, rather than silently ignoring--batchand entering the REPL. We must use aNonetest rather than a general truthiness test.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).