Open
Conversation
The overall process is more lenient now: * It's safe to call `/api/submit` more than once -- even after `/api/upload_code` * It's safe to call `/api/upload_code` more than once or don't call it at all -- code upload is now optional -- if we have nothing to upload, we can skip this step Since `/api/upload_code` is now optional, the server no longer calls this method if there is no code (`RemoteRepo` diff or `VirtualRepo` file archive) to upload. In addition, Python API (used by CLI internally) has been optimized -- it does not upload a code blob in there is no diff (`RemoteRepo`) or no files (empty `VirtualRepo`, incl. default virtual repo used when no repo specified in the run configuration). Fixes: #3740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overall process is more lenient now:
/api/submitmore than once -- even after/api/upload_code/api/upload_codemore than once or don't call it at all -- code upload is now optional -- if we have nothing to upload, we can skip this stepSince
/api/upload_codeis now optional, the server no longer calls this method if there is no code (RemoteRepodiff orVirtualRepofile archive) to upload. In addition, Python API (used by CLI internally) has been optimized -- it does not upload a code blob in there is no diff (RemoteRepo) or no files (emptyVirtualRepo, incl. default virtual repo used when no repo specified in the run configuration).Fixes: #3740