fix: guard against duplicate Fusebox DevTools dispatcher initialization#56316
fix: guard against duplicate Fusebox DevTools dispatcher initialization#56316am6737 wants to merge 1 commit intofacebook:mainfrom
Conversation
When using Expo dev client, switching the app from background to foreground can cause 'TypeError: property is not writable' in setUpFuseboxReactDevToolsDispatcher. The issue occurs because Metro HMR may invalidate module cache during foreground transitions, causing setUpDefaultReactNativeEnvironment to be re-executed and its initialized guard to be reset. This leads to Object.defineProperty on __FUSEBOX_REACT_DEVTOOLS_DISPATCHER__ running twice. The fix is to make the property definition idempotent by checking if it already exists before defining it.
|
Hi @am6737! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
When using Expo dev client, switching the app from background to foreground can cause TypeError: property is not writable in setUpFuseboxReactDevToolsDispatcher.js .
This issue only affects development builds - production builds are not affected because:
The issue occurs because Metro HMR may invalidate module cache during foreground transitions, causing setUpDefaultReactNativeEnvironment to be re-executed and its initialized guard to be reset. This leads to Object.defineProperty on FUSEBOX_REACT_DEVTOOLS_DISPATCHER running twice with configurable: false and writable: false , which throws an error.
Root cause:
The fix makes the property definition idempotent by checking if it already exists before defining it.
error log
Changelog:
[GENERAL] [FIXED] - Guard against duplicate Fusebox DevTools dispatcher initialization during HMR reconnection
Test Plan: