Conversation
This PR was created automatically to batch release the `go_router`.
fluttergithubbot
added
the
post-release-go_router
github-actions
bot
added
p: go_router
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the go_router package to version 17.2.0, introducing a fix for navigation callbacks in Block.then() and Allow.then() and adding encoder, decoder, and compare parameters to the TypedQueryParameter annotation. A review comment suggests a more precise description in the changelog regarding the application of these parameters in type-safe route constructors.
| ## 17.2.0 | ||
|
|
||
| - Fixes `Block.then()` and `Allow.then()` navigation callbacks being silently lost when triggered by `refreshListenable` due to re-entrant route processing. | ||
| - Adds `encoder`, `decoder` and `compare` parameters to `TypedQueryParameter` annotation for custom encoding, decoding and comparison of query parameters in `TypedGoRoute` constructors. |
There was a problem hiding this comment.
The phrasing "TypedGoRoute constructors" is slightly inaccurate and potentially confusing. TypedGoRoute is the annotation class itself, and its constructor does not accept these parameters. The TypedQueryParameter annotation is actually used on parameters within the constructors of user-defined classes that extend GoRouteData (or RelativeGoRouteData). Referring to them as "type-safe route constructors" or "GoRouteData constructors" would be more precise and consistent with the documentation for this feature.
| - Adds `encoder`, `decoder` and `compare` parameters to `TypedQueryParameter` annotation for custom encoding, decoding and comparison of query parameters in `TypedGoRoute` constructors. | |
| - Adds `encoder`, `decoder` and `compare` parameters to `TypedQueryParameter` annotation for custom encoding, decoding and comparison of query parameters in type-safe route constructors. |
chunhtai
added
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/11425, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
blocked on #11429 |
2 participants
This automated PR syncs the changes from the release branch release-go_router back to the main branch.