Conversation
- Updated nodejs and test harness dependencies - Re-ran code generators - Formatted generated code
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s Copilot CLI dependency to @github/copilot@1.0.17 and regenerates the protocol-derived types across Node.js, Python, Go, and .NET so SDKs stay in sync with the updated CLI schema.
Changes:
- Bumped
@github/copilotto^1.0.17in the Node.js SDK and the test harness (and updated lockfiles). - Regenerated protocol/type outputs across languages (new fields + enum variants).
- Refreshed the Node.js samples lockfile to match the updated SDK dependency tree.
Reviewed changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/harness/package.json | Bumps @github/copilot devDependency to ^1.0.17. |
| test/harness/package-lock.json | Lockfile updates for @github/copilot@1.0.17 and platform optional deps. |
| nodejs/package.json | Bumps SDK dependency on @github/copilot to ^1.0.17. |
| nodejs/package-lock.json | Lockfile updates for @github/copilot@1.0.17 and platform optional deps. |
| nodejs/samples/package-lock.json | Updates file-linked SDK package metadata to reflect new dependency versions. |
| nodejs/src/generated/session-events.ts | Regenerated event typings (adds mcpServerName, resolvedByHook, new permission result kind, updated docs). |
| nodejs/src/generated/rpc.ts | Regenerated RPC typings (adds new permission-result variant + fields). |
| python/copilot/generated/session_events.py | Regenerated session event models (adds mcp_server_name, resolved_by_hook, enum addition, doc updates). |
| python/copilot/generated/rpc.py | Regenerated RPC models (adds permission-result enum value and interrupt). |
| go/generated_session_events.go | Regenerated event structs/enums (adds ResolvedByHook, MCPServerName, enum addition, doc updates). |
| go/rpc/generated_rpc.go | Regenerated RPC structs/enums (adds Interrupt, enum addition). |
| dotnet/src/Generated/SessionEvents.cs | Regenerated event models (adds ResolvedByHook, McpServerName, enum addition, doc updates). |
Files not reviewed (3)
- nodejs/package-lock.json: Language not supported
- nodejs/samples/package-lock.json: Language not supported
- test/harness/package-lock.json: Language not supported
When the runtime resolves a permission request via a permissionRequest hook, it sets resolvedByHook=true on the broadcast event. The SDK broadcast handlers were unconditionally invoking the permission handler and sending an RPC response, causing duplicate/invalid responses. Add a guard in all four SDKs (Node, Python, Go, .NET) to skip the permission handler and RPC response when resolvedByHook is set, while still allowing event subscribers to observe the event. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cross-SDK Consistency Review ✅ (with one minor gap)This PR correctly regenerates all SDK generated files across all four SDKs (Node.js, Python, Go, .NET) from the new
Minor follow-up considerationThe
This creates a subtle API inconsistency: Node.js users can return This may be intentional if This is a pre-existing structural difference (Node.js derives its public type from generated code; others hand-maintain it), so it's reasonable to track as a separate follow-up rather than blocking this automated PR.
|
Automated update of
@github/copilotto version1.0.17.Changes
@github/copilotinnodejs/package.jsonandtest/harness/package.jsonscripts/codegen)