fix(models): register gemma 4 model names#5158
Open
pandego wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Gemma.supported_models()only matchesgemma-3.*#51562. Or, if no issue exists, describe the change:
Problem:
LLMRegistryonly matchedgemma-3.*, so string model names likegemma-4-31b-itwere rejected even though the underlying Gemini-backed Gemma path already supports them.Solution:
Broaden
Gemma.supported_models()to match the fullgemma-*family and add a registry regression test covering Gemma 3 plus Gemma 4 model names.Testing Plan
Unit Tests:
Passed locally:
uv sync --extra testuv run pytest tests/unittests/models/test_models.py tests/unittests/models/test_gemma_llm.pyManual End-to-End (E2E) Tests:
Not run for this focused registry fix.
Checklist
Additional context
This keeps the fix narrowly scoped to registry matching. It does not change Gemma request handling itself.