Add string extensions quote and reverse#998
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Add `strings.quote` and `reverse` extensions to match Go implementations.
0904d0d to
75fafc9
Compare
|
I wasn't sure if these were left out of the string extensions intentionally, but these were two that I saw implemented in cel-go but weren't in cel-java. The third one |
Thanks for the contribution. This was just work we hadn't been able to get to, and should definitely be added in CEL-Java. I'll review more thoroughly soon but in the meanwhile -- would you mind enabling the conformance tests for https://github.com/google/cel-java/blob/main/conformance/src/test/java/dev/cel/conformance/BUILD.bazel#L123 |
|
Enabled |
l46kok
left a comment
There was a problem hiding this comment.
Please add the newly added function to the documentation: https://github.com/google/cel-java/blob/main/extensions/src/main/java/dev/cel/extensions/README.md?plain=1#L388
You should be able to copy the relevant sections from go's README: https://github.com/google/cel-go/blob/master/ext/README.md
extensions/src/main/java/dev/cel/extensions/CelStringExtensions.java
Outdated
Show resolved
Hide resolved
extensions/src/test/java/dev/cel/extensions/CelStringExtensionsTest.java
Show resolved
Hide resolved
extensions/src/test/java/dev/cel/extensions/CelStringExtensionsTest.java
Show resolved
Hide resolved
extensions/src/test/java/dev/cel/extensions/CelStringExtensionsTest.java
Show resolved
Hide resolved
|
Thanks for the thorough review. I believe I've addressed the feedback - only question is on #998 (comment). |
Add
strings.quoteandreverseextensions to match Go implementations.