ci: set retention-days on platform binary artifacts in build job#3556
ci: set retention-days on platform binary artifacts in build job#3556Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
the
size/S
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
the
needs-ok-to-test
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to reduce long-term artifact storage by setting explicit retention on cross-platform binary artifacts, and also adjusts disk-space management steps in CI jobs.
Changes:
- Set
retention-days: 30for all 7 platform binary uploads in thefunctions.yamlbuildjob. - Replace/add disk cleanup steps using
endersonmenezes/free-disk-space@v3in CI workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/functions.yaml | Adds retention-days: 30 to binary artifacts in build; also adds a disk cleanup step to the Podman E2E job. |
| .github/workflows/test-podman-next.yaml | Replaces manual removal of preinstalled software with a free-disk-space action step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The seven cross-platform binaries were using GitHub's default 90-day retention. Cluster-log artifacts in the same file already use 7 days. Setting 30 days on binaries aligns retention with a reasonable policy and prevents unbounded storage accumulation.
Ankitsinghsisodya
force-pushed
the
ci/add-retention-days-to-build-artifacts
branch
from
339c29a to
4b5658f
Compare
knative-prow
bot
added
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3556 +/- ##
==========================================
+ Coverage 55.52% 56.23% +0.70%
==========================================
Files 180 180
Lines 20465 20465
==========================================
+ Hits 11363 11508 +145
+ Misses 7902 7757 -145
Partials 1200 1200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #3555
Summary
buildjob uploads 7 cross-platform binaries with noretention-dayssetting, causing them to use GitHub's default 90-day retention.retention-days: 7.retention-days: 30to all 7 binary artifact upload steps (darwin/amd64, darwin/arm64, linux/amd64, linux/arm64, linux/ppc64le, linux/s390x, windows/amd64) to align retention policy and prevent unbounded storage accumulation.Test plan
.github/workflows/functions.yamlbuild job now hasretention-days: 30on all 7actions/upload-artifact@v4steps.