ci: add actions/setup-python before smoke tests in update-python-platform#3564
Conversation
…form Without an explicit setup-python step, the smoke tests run against whatever Python version happens to be on the runner image, which may differ from the project's required Python 3.10. Closes knative#3561
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Ensures the update-python-platform.yaml workflow runs Python smoke tests against the project’s intended Python version (3.10) by explicitly installing it in CI, avoiding reliance on the runner’s preinstalled Python.
Changes:
- Add
actions/setup-python@v5to install Python 3.10 before runningmake test-pythonin theupdate-python-platformworkflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3564 +/- ##
==========================================
+ Coverage 53.76% 56.23% +2.46%
==========================================
Files 180 180
Lines 20465 20465
==========================================
+ Hits 11004 11509 +505
+ Misses 8355 7756 -599
- Partials 1106 1200 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Problem
The
update-python-platform.yamlworkflow runsmake test-pythonwithout first installing a specific Python version. This couples CI to the runner's pre-installed Python, which may differ from the project's required Python 3.10.Fix
Add
uses: actions/setup-python@v5withpython-version: "3.10"before the smoke test step, consistent with thePYTHON_VERSION: "3.10"used infunctions.yaml.Closes #3561