Skip to content

feat: [none] Add ctrl+alt+del button to Glish#13514

Open
slepix wants to merge 1 commit intolinode:developfrom
slepix:feat/ctrl-alt-del
Open

feat: [none] Add ctrl+alt+del button to Glish#13514
slepix wants to merge 1 commit intolinode:developfrom
slepix:feat/ctrl-alt-del

Conversation

@slepix
Copy link
Copy Markdown

@slepix slepix commented Mar 21, 2026

Description 📝

Even though Windows are not officially supported, this PR add a "CTRL+ALT+DEL" button in Glish console and brings us a small step closer to supporting Windows.

Changes 🔄

  • added a new Send Ctrl+Alt+Del button to the Glish VNC view
  • implemented RFB key handling for Ctrl, Alt, and Delete and sends the combo in correct press/release order
  • wrapped the VNC screen in a container so the button can be positioned as an overlay at the bottom-right
  • updated layout sizing to account for the new button area (100vh - 110px instead of 100vh - 60px)
  • imported Button and adds styled button/container components for the new control

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Up to your discretion

Preview 📷

Preview of Glish working for both Linux and Windows VM's.
Screenshot_20260321_011730-1

Windows VM on the login screen, waiting for CTRL+ALT+DEL combo to be sent:
Screenshot_20260321_012307

Windws VM after the CTRL+ALT+DEL button was pressed.
Screenshot_20260321_012320

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
glish-before glish-ctrlaltdev

How to test 🧪

Open Glish on a Windows based VM and press the CTRL+ALT+DEL button

Prerequisites

Regular environment setup. For windows VM use https://github.com/kitknox/winode

Verification steps

(How to verify changes)

Open Glish on a Windows based VM and press the CTRL+ALT+DEL button

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@slepix slepix requested a review from a team as a code owner March 21, 2026 00:32
@bnussman-akamai bnussman-akamai added Enhancement Linodes Dealing with the Linodes section of the app labels Mar 24, 2026
@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing841 Passing11 Skipped39m 0s

Warning

⌛ Test run timed out. This likely means a large number of tests failed. Please review results before proceeding.

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with LKE-E→shows the LKE-E flow with the feature flag on » creates an LKE-E cluster with the account capability

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"

@slepix
Copy link
Copy Markdown
Author

slepix commented Apr 3, 2026

Ehlo,

can someone re-kick the tests? My code didn't touch anything object storage/lke related so I think those test failures are unrelated to my code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Linodes Dealing with the Linodes section of the app

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants