feat: add Copilot agentic workflows and harness engineering improvements#35929
Draft
tudorpopams wants to merge 12 commits intomicrosoft:masterfrom
Draft
feat: add Copilot agentic workflows and harness engineering improvements#35929tudorpopams wants to merge 12 commits intomicrosoft:masterfrom
tudorpopams wants to merge 12 commits intomicrosoft:masterfrom
Conversation
…, docs, and skills improvement Adds five custom Copilot agent profiles (.github/agents/*.agent.md) for: - triage: classify, label, and route incoming issues - fix: implement bug fixes and open PRs - devils-advocate: critically review PRs with confidence scoring - docs-groomer: audit documentation for staleness and gaps - skills-improver: analyze agent performance and improve instructions Also adds global copilot-instructions.md and issue templates for periodic docs audits and skills reviews. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… skills Adds five agentic workflows (.md + compiled .lock.yml): - agent-triage: classifies, labels, and validates incoming issues - agent-fix: implements bug fixes and opens PRs (triggered by agent:fix label) - agent-review: devil's advocate review with confidence scoring for agent PRs - agent-docs-grooming: weekly documentation audit - agent-skills-improvement: weekly analysis of agent PRs to improve instructions Also includes gh-aw init scaffolding (agentic-workflows agent, .gitattributes). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These are superseded by the agentic workflows (agent-*.md + .lock.yml). Keeps copilot-instructions.md as global context for all Copilot agents. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merges global agent context (from .github/copilot-instructions.md) into AGENTS.md alongside the existing Nx guidelines. CLAUDE.md is a symlink to AGENTS.md so both Claude Code and Copilot read the same instructions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Applies progressive disclosure, mechanical enforcement, and feedback loop patterns from OpenAI's harness engineering approach. 1. Progressive disclosure: Slim down copilot.instructions.md (473→50 lines) and AGENTS.md into pointer-only maps. Detailed docs moved to docs/: - docs/architecture/component-patterns.md (v9 hooks, slots, Griffel) - docs/architecture/design-tokens.md (token categories and usage) - docs/architecture/layers.md (package dependency tiers) - docs/workflows/contributing.md (PR checklist, commands) - docs/workflows/testing.md (test types, SSR safety) - docs/team-routing.md (teams, labels, CODEOWNERS) 2. Agent-guiding error messages: Updated all custom ESLint rules to include doc URLs and fix instructions in error messages so agents self-correct. 3. New ESLint rule: @fluentui/no-hardcoded-style-values — flags hardcoded colors and spacing in .styles.ts files, requiring design tokens. 4. Structural validation: check-v9-structure.js validates that component packages follow the canonical file structure. 5. Layer boundary validation: check-layer-boundaries.js validates that component packages (Tier 3) don't depend on other component packages. 6. Quality tracking: docs/quality-grades.md and docs/tech-debt-tracker.md for agents and engineers to track package quality and debt. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Removes no-hardcoded-style-values ESLint rule, check-layer-boundaries.js, and check-v9-structure.js as requested. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3,3 +3,5 @@ | |||
|
|
|||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png | 7530 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png | 605 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 748 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 183 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 31 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 45 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 31 | Changed |
vr-tests-web-components/Accordion 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Accordion. - Dark Mode.normal.chromium_1.png | 3154 | Changed |
vr-tests-web-components/Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png | 298 | Changed |
vr-tests/Callout 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Bottom left edge - RTL.default.chromium.png | 2199 | Changed |
| vr-tests/Callout.Bottom right edge - RTL.default.chromium.png | 1124 | Changed |
| vr-tests/Callout.Rendering callout attached to a rectangle.default.chromium.png | 1835 | Changed |
| vr-tests/Callout.Bottom right edge.default.chromium.png | 1130 | Changed |
| vr-tests/Callout.Left bottom edge.default.chromium.png | 3182 | Changed |
| vr-tests/Callout.Right bottom edge.default.chromium.png | 3095 | Changed |
| vr-tests/Callout.Right center.default.chromium.png | 2117 | Changed |
vr-tests/Coachmark 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Coachmark.Collapsed.default.chromium.png | 159 | Changed |
vr-tests/Keytip 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Keytip.Offset.default.chromium.png | 86 | Changed |
vr-tests/react-charting-MultiStackBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-MultiStackBarChart.Basic_Absolute - Dark Mode.default.chromium.png | 363 | Changed |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Applies findings from "Increasing AI coding success to 99%" article:
- Add "instructions are source of truth, not existing code" as first line
- Add critical rules as negative constraints ("Never X") in always-loaded context
- Add concrete v9 component code template to override training defaults
- Add legacy anti-patterns section warning about v8 code agents will find
- Add exploration guidance for the large monorepo
- Reframe positive guidance as negative constraints for higher compliance
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The main goal for this PR is to enable GitHub Agentic Workflows within the repo and implement Harness engineering best practices.
AGENTS.mdas a map, detailed docs indocs/CLAUDE.mdsymlinked toAGENTS.mdfor cross-tool compatibilityWhat's included
Agentic Workflows (
.github/workflows/agent-*.md)agent-triageagent-fixagent:fixlabel addedagent-reviewagent-docs-groomingagent-skills-improvementHarness Engineering (docs/ restructure)
AGENTS.mdslimmed to ~60 lines as a pointer-only map.github/instructions/copilot.instructions.mdreduced from 473 to ~50 linesdocs/architecture/component-patterns.md— v9 hooks, slots, Griffeldocs/architecture/design-tokens.md— token categories and usagedocs/architecture/layers.md— package dependency tiersdocs/workflows/contributing.md— PR checklist and commandsdocs/workflows/testing.md— test types and SSR safetydocs/team-routing.md— teams, labels, CODEOWNERSdocs/quality-grades.md— per-package quality trackingdocs/tech-debt-tracker.md— known debt items for agentsESLint Error Message Improvements
Updated 5 existing rules (
ban-context-export,ban-instanceof-html-element,no-global-react,no-restricted-imports,no-context-default-value) toinclude fix instructions and
docs/references in error messages.Test plan
GH_AW_AGENT_TOKENsecret (fine-grained PAT)agent-triageworkflow runsagent:fixlabel to an issue and verifyagent-fixworkflow runsagent-reviewtriggers on agent-created PRsagent-docs-groomingandagent-skills-improvementviagh aw run