Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Docker release pipeline and manifest publishing script to emit additional “minor version” tags (e.g., 2.0) alongside the full version and latest, enabling consumers to pin to a minor line while still receiving patch updates.
Changes:
- Add logic to publish multi-arch manifests for
${major}.${minor}tags when the version is a stable SemVer. - Update the Docker release pipeline to also push
${major}.${minor}-<arch>tags for stable versions. - Improve script output messaging around when minor-version tags are skipped.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/scripts/Publish-DockerManifests.ps1 | Publishes an additional minor-version multi-arch manifest tag (stable versions only). |
| eng/pipelines/templates/jobs/docker/release-docker.yml | Pushes additional minor-version arch tags and wires them into the release job. |
jongio
left a comment
There was a problem hiding this comment.
One open question on the 1ES.PushContainerImage@1 task's remoteImage input - see inline comment. The inconsistent stability predicate between YAML and PS1 was already flagged in the Copilot review.
| inputs: | ||
| image: $(SetReleaseVariables.DockerImageName):amd64 | ||
| remoteImage: ${{ parameters.ContainerRegistry }}.azurecr.io/${{ parameters.DeploymentEnvironment }}/$(SetReleaseVariables.DockerImageName):$(SetReleaseVariables.DockerImageVersion)-amd64 | ||
| remoteImage: $(SetReleaseVariables.Amd64RemoteImages) |
There was a problem hiding this comment.
[INFO] API Contract: For stable releases, Amd64RemoteImages resolves to a comma-separated pair (e.g., repo:2.0.0-amd64,repo:2.0-amd64). Does 1ES.PushContainerImage@1 handle comma-separated remoteImage inputs? If it only accepts a single tag, the minor version arch images won't get pushed.
What does this PR do?
To allow for previous version patching without bumping everyone to a patch of a previous minor, we'll start publishing multiple tags like 2.0.1-amd64, 2.0-amd64, 2.0, latest
GitHub issue number?
#1495
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline