Open
Conversation
tianleiwu
reviewed
Apr 2, 2026
| if (vector_count_ > 0) { | ||
| feature_count_ = support_vectors_.size() / vector_count_; // length of each support vector | ||
| mode_ = SVM_TYPE::SVM_SVC; | ||
| ORT_ENFORCE(static_cast<int64_t>(vectors_per_class_.size()) == class_count_, "Mismatch between class_labels and vector_per_class dimensions."); |
Contributor
There was a problem hiding this comment.
suggest to change *_count_ type to size_t so we need not cast here.
onnxruntime/onnxruntime/core/providers/cpu/ml/svmclassifier.h
Lines 123 to 125 in 9679207
That could avoid other casts like:
…xadupre/si-svm-111801
tianleiwu
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vector_per_class dimension was not verified, it could lead to illegal memory access
Motivation and Context
security issue