fix(rush): Allow 'rush-pnpm' to forward arbitrary commands#5745
Closed
aryanjsingh wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(rush): Allow 'rush-pnpm' to forward arbitrary commands#5745aryanjsingh wants to merge 1 commit intomicrosoft:mainfrom
aryanjsingh wants to merge 1 commit intomicrosoft:mainfrom
Conversation
aryanjsingh
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 'rush-pnpm' command was not correctly forwarding commands like 'outdated' to pnpm because it was missing a default action. This change configures a default action for 'rush-pnpm' to pass through arbitrary commands. It also corrects the working directory to 'common/temp', which is necessary for pnpm workspace commands to function correctly.
Changes
PnpmAction.ts, set the action as the default to catch arbitrary commands likeoutdated. Additionally, update theworkingDirectorytocommonTempFolderto ensure pnpm workspace commands execute in the correct context.Related Issue
Closes #5035