chat: remove Preview label and customizationsMenu.enabled setting#307744
chat: remove Preview label and customizationsMenu.enabled setting#307744joshspicer wants to merge 1 commit intomainfrom
Conversation
Remove the "(Preview)" suffix from the Chat Customizations command titles and remove the `chat.customizationsMenu.enabled` setting that gated the feature. The customizations editor is now always available when chat is enabled. - Remove ChatCustomizationMenuEnabled constant and setting registration - Simplify when-clauses to only check ChatContextKeys.enabled - Remove legacy gear submenu fallback for disabled state - Clean up unused imports across 3 files - Update AI_CUSTOMIZATIONS.md documentation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the preview gating around the Chat Customizations editor by deleting the chat.customizationsMenu.enabled setting, dropping the (Preview) suffix from related command titles, and simplifying all preconditions/when-clauses to only depend on ChatContextKeys.enabled.
Changes:
- Removed
chat.customizationsMenu.enabled/ChatCustomizationMenuEnabledand updated all gating to rely onChatContextKeys.enabled. - Updated command titles to remove
(Preview)for Customizations-related commands. - Removed the legacy gear submenu fallback and updated docs to reflect the setting removal.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/constants.ts | Removes ChatCustomizationMenuEnabled from ChatConfiguration. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Removes configuration registration for chat.customizationsMenu.enabled. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.contribution.ts | Updates Customizations command titles; simplifies preconditions to ChatContextKeys.enabled. |
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Simplifies when-clauses and removes the legacy gear submenu fallback. |
| src/vs/workbench/contrib/chat/browser/actions/chatOpenAgentDebugPanelAction.ts | Simplifies ViewTitle when-clause and removes unused import. |
| src/vs/workbench/contrib/chat/browser/tools/toolSetsContribution.ts | Simplifies ViewTitle when-clause and removes unused import. |
| src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts | Removes references to the deleted setting from hidden-status logic and config listeners. |
| src/vs/workbench/browser/parts/titlebar/commandCenterControl.ts | Removes the deleted setting from compact-mode logic. |
| src/vs/sessions/AI_CUSTOMIZATIONS.md | Updates documentation to remove references to the deleted setting. |
Copilot's findings
- Files reviewed: 9/9 changed files
- Comments generated: 2
| @@ -1465,20 +1465,9 @@ export function registerChatActions() { | |||
| when: ContextKeyExpr.and( | |||
| ChatContextKeys.enabled, | |||
| ContextKeyExpr.equals('view', ChatViewId), | |||
| ContextKeyExpr.has(`config.${ChatConfiguration.ChatCustomizationMenuEnabled}`) | |||
| ), | |||
| order: 6 | |||
| }); | |||
There was a problem hiding this comment.
CHAT_CONFIG_MENU_ID no longer appears to be surfaced anywhere after removing the ViewTitle submenu entry (there are no remaining submenu: CHAT_CONFIG_MENU_ID / createMenu(CHAT_CONFIG_MENU_ID) usages in the repo). That means items contributed only to CHAT_CONFIG_MENU_ID (e.g. Plugins, Instructions/Skills management, MCP Servers, etc.) will stop showing up in the Chat UI. Consider either (1) reintroducing a ViewTitle submenu/overflow entry to expose CHAT_CONFIG_MENU_ID, or (2) migrating remaining contributions off CHAT_CONFIG_MENU_ID to MenuId.ViewTitle and then removing the menu id entirely.
| ## Settings | ||
|
|
||
| Settings use the `chat.customizationsMenu.` and `chat.customizations.` namespaces: | ||
| Settings use the `chat.customizations.` namespace: |
There was a problem hiding this comment.
The doc now states that settings use only the chat.customizations. namespace, but the codebase still contains at least one chat.customizationsMenu.* key (chat.customizationsMenu.userStoragePath is set as a sessions default override in src/vs/sessions/contrib/configuration/browser/configuration.contribution.ts). Consider clarifying the wording here (e.g., "User-facing settings use...") or renaming/removing the remaining chat.customizationsMenu.* key to avoid confusion.
| Settings use the `chat.customizations.` namespace: | |
| User-facing settings use the `chat.customizations.` namespace: |
Summary
The Chat Customizations editor is no longer behind a preview gate. This PR:
(Preview)suffix from the "Open Customizations" and "Customizations" command titleschat.customizationsMenu.enabledsetting and itsChatCustomizationMenuEnabledconstantChatContextKeys.enabledinstead of also checking the now-removed settingChatConfigurationimports from 3 filesAI_CUSTOMIZATIONS.mddocumentation to reflect the removalChanges by file
constants.tsChatCustomizationMenuEnabledenum memberchat.contribution.tsaiCustomizationManagement.contribution.ts(Preview)from titles, simplify preconditions, remove unused importchatActions.tschatOpenAgentDebugPanelAction.tstoolSetsContribution.tsagentTitleBarStatusWidget.tsshouldForceHiddenAgentStatusand config change listenerscommandCenterControl.tsAI_CUSTOMIZATIONS.md