examples: add healthchecks and service_healthy depends_on to mariadb …#2565
Open
Neha-2005-VCE wants to merge 1 commit intonextcloud:masterfrom
Open
examples: add healthchecks and service_healthy depends_on to mariadb …#2565Neha-2005-VCE wants to merge 1 commit intonextcloud:masterfrom
Neha-2005-VCE wants to merge 1 commit intonextcloud:masterfrom
Conversation
…apache Closes nextcloud#2250 Signed-off-by: Neha Goud <nehagoud300@gmail.com>
Neha-2005-VCE
force-pushed
the
add-healthchecks-mariadb-redis
branch
from
27dd5fe to
e5fc179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds healthcheck blocks to the db (MariaDB) and redis services.
Updates depends_on in app and cron to use condition: service_healthy.
Why?
Without healthchecks, Docker marks a container as ready the moment
it starts, not when it is actually accepting connections. This causes
race conditions on first install where Nextcloud tries to connect to
MariaDB before it has finished initializing.
Closes #2250