Skip to content

tools: improve backport review script#62573

Open
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:improve-backport-review
Open

tools: improve backport review script#62573
aduh95 wants to merge 2 commits intonodejs:mainfrom
aduh95:improve-backport-review

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 3, 2026

  • Print a error message when gh is not on the PATH
  • Let the CLI argument be interpreted by gh instead of assuming it's always a URL (i.e. support passing only the PR number)
  • Set up trap handler to properly remove the temp files
  • Add a prompt to quickly approve the backport PR

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 3, 2026
@aduh95 aduh95 requested a review from panva April 4, 2026 09:03
@panva
Copy link
Copy Markdown
Member

panva commented Apr 4, 2026

@aduh95 i don't follow, is this something i should've been using to open backport PRs? I was following doc/contributing/backporting-to-release-lines.md Or is this meant to auto approve backports? I'm lost :D

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Apr 4, 2026

It's a tool to review backports, so to be used after the backport PR has been opened. I'm asking you a review because I used it to recently review your backports; at some point we could have GHA auto-review the backport PRs, but until then it makes manual reviews much easier.

Copy link
Copy Markdown
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants