Document Retry-After header support for async retries#425
Open
welteki wants to merge 1 commit intoopenfaas:masterfrom
Open
Document Retry-After header support for async retries#425welteki wants to merge 1 commit intoopenfaas:masterfrom
welteki wants to merge 1 commit intoopenfaas:masterfrom
Conversation
Add a section explaining how functions can return a Retry-After header on 429 responses to control the retry delay. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewSummary
Approval rating (1-10)8 - Well-written documentation for a useful feature, accurate and clear, no major issues found. Summary per fileSummary per file
Overall AssessmentThe PR successfully documents the Retry-After header feature for async retries in OpenFaaS Pro. The documentation is clear, accurate, and integrates well with the existing retries guide. No technical issues or inconsistencies identified. Detailed ReviewDetailed Reviewdocs/openfaas-pro/retries.md
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new "Retry-After header" section to the retries documentation explaining
how functions can return a
Retry-Afterheader on 429 responses to controlthe next retry delay in the queue-worker.
Motivation and Context
The jetstream queue-worker now supports the
Retry-Afterresponse header.This documents the feature for users.
How Has This Been Tested?
Reviewed the rendered output locally against the existing doc structure.
Types of changes
Checklist:
git commit -s