Open
Conversation
Collaborator
Author
|
Will update the docs as a separate PR. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable “generic” Helm chart for JOSDK-based operators, updates the metrics-processing E2E deployment to use Helm, and enables Helm chart unit tests in PR CI.
Changes:
- Introduced
helm/generic-helm-chart(templates + default values + helm-unittest tests). - Updated metrics-processing E2E to install/uninstall the operator via Helm (instead of applying
k8s/operator.yaml). - Added a PR workflow job to run Helm unit tests via a helper script.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sample-operators/metrics-processing/src/test/resources/helm-values.yaml | Adds Helm values used by the metrics-processing E2E to deploy via the generic chart |
| sample-operators/metrics-processing/src/test/java/.../MetricsHandlingE2E.java | Switches cluster E2E operator deployment to Helm install/uninstall; refactors command/script execution helpers |
| sample-operators/metrics-processing/src/main/java/.../MetricsHandlingSampleOperator.java | Prepares config providers for env var + /config/config.yaml based configuration (not yet wired in shown diff) |
| sample-operators/metrics-processing/pom.xml | Configures JVM flag to load Log4j2 config from /config/log4j2.xml (matches chart-mounted config) |
| helm/run-tests.sh | Adds script to install helm-unittest plugin and run chart unit tests |
| helm/generic-helm-chart/* | Adds generic reusable Helm chart and helm-unittest suites for core rendered resources |
| .github/workflows/pr.yml | Adds CI job to run Helm unit tests on PRs |
.../src/main/java/io/javaoperatorsdk/operator/sample/metrics/MetricsHandlingSampleOperator.java
Show resolved
Hide resolved
Collaborator
Author
|
Will update docs as a separate PR since, we would now deserve an "operations" section in docs |
- adds generic helm chart that can be reused and extended by users for their operators - adjusts metrics processing e2e test to use that helm chart - adjusts PR to run unit tests for helm chart Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.