Fix GH-21600: Remove xsltCleanupGlobals call in ext/xsl MSHUTDOWN.

[devnexen]

The call to xsltCleanupGlobals() during module shutdown can cause a segfault in xmlHashFree() when freeing libxslt internal hash tables. This is the same class of shutdown cleanup issue that led to xmlCleanupParser() being removed from ext/libxml. The process is about to exit and the OS will reclaim all memory, making the explicit cleanup both unnecessary and harmful.

[ndossche]

It's a bit strange. I'd like to first better understand what is causing the segfault.
I'm assuming you were able to reproduce this. If so, can you run it under Valgrind (without this patch) and USE_ZEND_ALLOC=0 ?

[devnexen]

I ran it under Valgrind with USE_ZEND_ALLOC=0 — valgrind is clean, but I wasn't able to reproduce the same circumstances as the original report (many shared
xml-related extensions loaded, Magento shutdown sequence).

That said, this is the same class of bug that was fixed in ext/libxml by 8742276 where xmlCleanupParser() was removed from
php_libxml_shutdown() for the same reason: "usage of xmlCleanupParser can affect the thread local storage, or even cause crashes in single threaded programs. On
shutdown the memory will be freed anyway."

xsltCleanupGlobals() is the xslt-side equivalent — it tears down global state (frees xsltFunctionsHash, xsltExtMutex, resets initialized = 0) that can be re-entered
by other extensions during shutdown, and the process is about to exit anyway.

[ndossche]

I think this may not actually fix the real problem, but I can't prove nor disprove this.
If this helps then sure.
In typical PHP fashion, the original referenced commit is borderline useless as it doesn't contain any useful background info.

[devnexen]

I think this may not actually fix the real problem, but I can't prove nor disprove this. If this helps then sure.

There is a more general issue with shared extensions loading order indeed.

In typical PHP fashion, the original referenced commit is borderline useless as it doesn't contain any useful background info.

Even tough you think it I hope you stick around a little bit ;)